Paths

Table of Contentst

Differential D16442

[Chronik] Add `get_block_header` to FFI
ClosedPublic
Actions

Authored by tobias_ruck on Jul 11 2024, 13:27.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa4e47f611a90: [Chronik] Add `get_block_header` to FFI

Summary

Returns the serialized block header of a given CBlockIndex, and expose it via FFI to Chronik.

Test Plan

ninja test_bitcoin && ./src/test/test_bitcoin -t chronikbridge_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Jul 11 2024, 13:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 11 2024, 13:27

tobias_ruck requested review of this revision.Jul 11 2024, 13:27

remove unnecessary bridge

add test for tip header too

Harbormaster completed remote builds in B29520: Diff 48577.Jul 11 2024, 13:51

Harbormaster completed remote builds in B29521: Diff 48578.Jul 11 2024, 13:58

Harbormaster completed remote builds in B29522: Diff 48579.Jul 11 2024, 14:07

OK, that looks like something I can use.

This revision is now accepted and ready to land.Jul 11 2024, 15:34

Closed by commit rABCa4e47f611a90: [Chronik] Add `get_block_header` to FFI (authored by tobias_ruck). · Explain WhyJul 11 2024, 15:38

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCa4e47f611a90: [Chronik] Add `get_block_header` to FFI.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-bridge/

src/

ffi.rs

7 lines

chronik-cpp/

chronik_bridge.h

2 lines

chronik_bridge.cpp

8 lines

test/

chronikbridge_tests.cpp

16 lines

Diff 48585

View Options

chronik/chronik-bridge/src/ffi.rs

View Options

chronik/chronik-cpp/chronik_bridge.h

View Options

chronik/chronik-cpp/chronik_bridge.cpp

View Options

chronik/test/chronikbridge_tests.cpp

[Chronik] Add `get_block_header` to FFIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48585

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-cpp/chronik_bridge.h

chronik/chronik-cpp/chronik_bridge.cpp

chronik/test/chronikbridge_tests.cpp

[Chronik] Add `get_block_header` to FFI
ClosedPublic
Actions

Revision Contents
Changeset List