when click copy the exact amount, remove copy-icon
Details
Details
- Reviewers
assasin-k7 - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- test-branch
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29534 Build 58603: Build Diff cashtab-tests · ecash-lib-tests Build 58602: arc lint + arc unit
Event Timeline
Comment Actions
this commit is not against master so I am not able to test it locally using arc patch
also means I am probably not able to really review your changes, some are probably missing from the diff
keep in mind that phab -- a diff must be only one change (one commit). If you made several commits on a branch, arc diff will not push up the whole change.
Here is my output from arc patch 16453
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16453.
This diff is against commit c6736b4e9940daecb8408800ebf82850c079db5c, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (a4e47f611a90942696fe876a213ded8e4fefea8d)
[Y/n]| cashtab/src/components/Common/Buttons.js | ||
|---|---|---|
| 112 | why is this css in a css group? It's not used anywhere else except for CopyAmountContainer, below | |
| 196 | what's with this character? | |
Comment Actions
- The diff has no title
- The diff has no summary, it's not clear what you are trying to do
- The diff cannot be locally tested because it is not based on master
when click copy the exact amount, remove copy-icon
this does not make sense for a test plan
overally, I'm not sure what this is supposed to do.