Page MenuHomePhabricator

Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE
ClosedPublic

Authored by Fabien on Aug 1 2024, 19:23.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC065b32f46618: Rename TX_RECONSIDERABLE to TX_PACKAGE_RECONSIDERABLE
Summary

This better convey the meaning of this validation result, and makes it easier to add other possible reconsideration reasons (e.g. pre-consensus). Same goes for the related bloom filter.

Rename only, there is no change in behavior.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Aug 1 2024, 19:23
PiRK added inline comments.
src/validation.h
191 ↗(On Diff #49002)

This sub-header line changed. "Other" is in the wrong column now

You probably need to split it over two lines to fit the 80 cols limit.

   TX_PACKAGE_
RECONSIDERABLE
PiRK requested changes to this revision.Aug 2 2024, 07:00
This revision now requires changes to proceed.Aug 2 2024, 07:00
This revision is now accepted and ready to land.Aug 2 2024, 08:47