Page MenuHomePhabricator
Differential D16591

[e.cash] Open wallet CTA in new tab
AbandonedPublic
Actions

Authored by johnkuney on Aug 5 2024, 21:20.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Open the wallet CTA in the new landing page to a new tab since it goes to a different site

Test Plan

preview the site and check the Create Wallet link opens in new tab

Diff Detail

Repository
rABC Bitcoin ABC
Branch
openinnewtab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29867
Build 59269: Build Diff
Build 59268: arc lint + arc unit

Event Timeline

johnkuney created this revision.Aug 5 2024, 21:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2024, 21:20
johnkuney requested review of this revision.Aug 5 2024, 21:20
Harbormaster completed remote builds in B29867: Diff 49046.Aug 5 2024, 21:20
bytesofman requested changes to this revision.Aug 5 2024, 21:39
bytesofman added a subscriber: bytesofman.

imo abandon and we'll land it from this one D16589

web/e.cash/components/button/index.js
52

this might be better than what I have in the competing diff -- but I haven't seen this _self before, where did you find this?

53

we will actually need the referrer here since we're going to be tracking conversions

This revision now requires changes to proceed.Aug 5 2024, 21:39
johnkuney abandoned this revision.Aug 5 2024, 23:13

ah my bad didnt see you had that one going

web/e.cash/components/button/index.js
52

its just the default value for target

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
button/
4 lines
pages/
1 line

Diff 49046

View Options

web/e.cash/components/button/index.js

Loading...
View Options

web/e.cash/pages/index.js

Loading...