Paths

Table of Contentst

Differential D16589

[e.cash] Open Cashtab in a new tab when user clicks Create Wallet
ClosedPublic
Actions

Authored by bytesofman on Aug 5 2024, 19:04.

Details

Reviewers

Kronkmeister

Group Reviewers

Restricted Project

Commits

rABC89681eba7a91: [e.cash] Open Cashtab in a new tab when user clicks Create Wallet

Summary

We should open Cashtab in a new tab and keep the landing page open when the user clicks "create wallet".

Add a new prop openInNewTab to the custom Button component so that Buttons may open links in a new tab. Implement for the "Create Wallet" button on the landing page above the fold.

Test Plan

Preview, click "Create Wallet", confirm Cashtab opens in a new tab

Confirm the "get eCash" button navigates without opening a new tab (previous behavior)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Aug 5 2024, 19:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2024, 19:04

Harbormaster completed remote builds in B29865: Diff 49042.Aug 5 2024, 19:04

bytesofman published this revision for review.Aug 5 2024, 19:05

bytesofman edited the test plan for this revision. (Show Details)

bytesofman mentioned this in D16591: [e.cash] Open wallet CTA in new tab.Aug 5 2024, 21:39

Kronkmeister accepted this revision.Aug 5 2024, 22:50

This revision is now accepted and ready to land.Aug 5 2024, 22:50

Closed by commit rABC89681eba7a91: [e.cash] Open Cashtab in a new tab when user clicks Create Wallet (authored by bytesofman). · Explain WhyAug 6 2024, 00:03

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC89681eba7a91: [e.cash] Open Cashtab in a new tab when user clicks Create Wallet.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

button/

index.js

2 lines

pages/

index.js

1 line

Diff 49048

View Options

web/e.cash/components/button/index.js