Page MenuHomePhabricator
Differential D16589

[e.cash] Open Cashtab in a new tab when user clicks Create Wallet
ClosedPublic
Actions

Authored by bytesofman on Aug 5 2024, 19:04.

Details

Reviewers
Kronkmeister
Group Reviewers
Restricted Project
Commits
rABC89681eba7a91: [e.cash] Open Cashtab in a new tab when user clicks Create Wallet
Summary

We should open Cashtab in a new tab and keep the landing page open when the user clicks "create wallet".

Add a new prop openInNewTab to the custom Button component so that Buttons may open links in a new tab. Implement for the "Create Wallet" button on the landing page above the fold.

Test Plan

Preview, click "Create Wallet", confirm Cashtab opens in a new tab

Confirm the "get eCash" button navigates without opening a new tab (previous behavior)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
landing-btn-newtab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29865
Build 59265: Build Diff
Build 59264: arc lint + arc unit

Revision Contents
Changeset List

PathSize
web/
e.cash/
components/
button/
2 lines
pages/
1 line

Diff 49042

View Options

web/e.cash/components/button/index.js

Loading...
View Options

web/e.cash/pages/index.js

Loading...