Paths

Table of Contentst

Differential D16601

[herald] Don't use the @ character to display the miner address
ClosedPublic
Actions

Authored by Fabien on Aug 7 2024, 17:44.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCc925dc26dfb9: [herald] Don't use the @ character to display the miner address

Summary

This doesn't play nicely with Telegram which interprets it as a handle. Use ... instead.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 7 2024, 17:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2024, 17:44

Fabien requested review of this revision.Aug 7 2024, 17:44

Harbormaster completed remote builds in B29891: Diff 49082.Aug 7 2024, 17:46

bytesofman accepted this revision.Aug 7 2024, 17:48

This revision is now accepted and ready to land.Aug 7 2024, 17:48

Closed by commit rABCc925dc26dfb9: [herald] Don't use the @ character to display the miner address (authored by Fabien). · Explain WhyAug 7 2024, 17:51

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc925dc26dfb9: [herald] Don't use the @ character to display the miner address.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

2 lines

test/

fixtures/

miners.js

14 lines

mocks/

block.js

6 lines

Diff 49085

View Options

apps/ecash-herald/src/parse.js

View Options

apps/ecash-herald/test/fixtures/miners.js

View Options

apps/ecash-herald/test/mocks/block.js

[herald] Don't use the @ character to display the miner addressClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49085

apps/ecash-herald/src/parse.js

apps/ecash-herald/test/fixtures/miners.js

apps/ecash-herald/test/mocks/block.js

[herald] Don't use the @ character to display the miner address
ClosedPublic
Actions

Revision Contents
Changeset List