Once placed in the dangling proof pool, proofs are not checked for validity.
Although they cannot be pulled back to become valid peers, it does not make sense to
hold onto them anymore.
This fix ensures dangling proofs are always valid.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC0664212b2379: [avalanche] Cleanup invalidated dangling proofs
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- invalidate-dangling-proofs
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29900 Build 59335: Build Diff lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-debug · build-diff · build-clang Build 59334: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Tail of the build log:
-- Installing: /results/artifacts/include/secp256k1_preallocated.h -- Installing: /results/artifacts/include/secp256k1_recovery.h -- Installing: /results/artifacts/include/secp256k1_schnorr.h [389/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [390/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o [391/571] Linking C executable src/secp256k1/internal-bench [392/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o [393/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o [394/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [395/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [396/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [397/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [398/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [399/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [400/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [401/571] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [402/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [403/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [404/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [405/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [406/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [407/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [408/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [409/571] Building CXX object src/CMakeFiles/server.dir/node/context.cpp.o [410/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [411/571] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o [412/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [413/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [414/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [415/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [416/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [417/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [418/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [419/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [420/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [421/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [422/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [423/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [424/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [425/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o [426/571] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [427/571] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [428/571] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [429/571] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [430/571] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [431/571] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [432/571] Linking CXX static library src/wallet/libwallet.a [433/571] Building CXX object src/CMakeFiles/server.dir/avalanche/proofpool.cpp.o [434/571] Building CXX object src/CMakeFiles/server.dir/node/miner.cpp.o [435/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [436/571] Building CXX object src/CMakeFiles/server.dir/node/blockstorage.cpp.o [437/571] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o [438/571] Building CXX object src/CMakeFiles/server.dir/avalanche/processor.cpp.o [439/571] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [440/571] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o [441/571] Building CXX object src/CMakeFiles/server.dir/init.cpp.o [442/571] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o [443/571] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o ninja: build stopped: cannot make progress due to previous errors. Build build-clang failed with exit code 1