Page MenuHomePhabricator

[explorer] Render cashaddr for all inputs and outputs on transaction page
AbandonedPublic

Authored by bytesofman on Aug 8 2024, 23:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

The block explorer has logic which changes the address format of the outputScript depending on whether or not the input or output sent or received tokens in the given tx.

This is an overcomplication. Just show the ecash address every time.

I think token inputs and outputs should be better highlighted. The "different address that looks the same as the other address" does not really do this. For now, we show the token ticker. I'll add the token icon in a separate diff.

Address conversion is still possible with the explorer on the address page.

Test Plan

cargo run, no errors, check a token tx, note all inputs and outputs have ecash: prefixed addresses on the tx page

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer-no-auto-etokenaddr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29912
Build 59359: Build Diff
Build 59358: arc lint + arc unit

Event Timeline

remove copy paste change from separate diff

bytesofman published this revision for review.Aug 8 2024, 23:53
Fabien requested changes to this revision.Aug 10 2024, 08:40

I don't think this is a good change. It seems more useful and more the expected behavior for a token transaction to show the token address, and the simplification is not a big gain in this case. I get the point that you can select your address format in the address page but I don't think it compensates for the annoyance.

This revision now requires changes to proceed.Aug 10 2024, 08:40