[Cashtab] Update tx history to parse eCashChat authentication txs
ClosedPublic
Actions

Authored by emack on Aug 11 2024, 12:19.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCdd17b5dae543: [Cashtab] Update tx history to parse eCashChat authentication txs

Summary

v1.5.2 of eCashChat will utilize onchain authentication transactions to verify ownership of addresses on mobile devices. This is done by passing a BIP21 querystring to Cashtab.com on mobile devices with a pre-populated dust send tx.

It's done this way because the use of signature verification is very laborious and Cashtab Extensions is not available on Android/iOS.

This diff updates Cashtab to recognize these transactions.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Aug 11 2024, 12:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 11 2024, 12:19

Harbormaster completed remote builds in B29932: Diff 49139.Aug 11 2024, 12:22

emack edited the summary of this revision. (Show Details)Aug 11 2024, 12:23

emack edited the summary of this revision. (Show Details)

emack published this revision for review.Aug 11 2024, 12:26

bytesofman requested changes to this revision.Aug 11 2024, 14:06

bytesofman added inline comments.

cashtab/src/chronik/index.js
204 ↗	(On Diff #49139)	this file isn't being changed at all by this diff...can you back out these formatting changes?
cashtab/src/components/Home/Tx/index.js
450 ↗	(On Diff #49139)	would be nice to include a brief spec of what such a tx is expected to look like in the parsing is there no case for "invalid auth tx" ? Just any app tx with the prefix and then anything else is an auth tx? if so, worth mentioning in a comment. Do you have a spec for the many types of ecash chat txs now possible somewhere? could add this to the monorepo doc? or mb a dev section on ecash chat?

This revision now requires changes to proceed.Aug 11 2024, 14:06

Updated comments

cashtab/src/components/Home/Tx/index.js
450 ↗	(On Diff #49139)	Added comment to indicate authentication tx opreturns are basically authPrefixHex + a random string. A websocket listens for a tx with an opreturn that contains that random string and if so, authenticates the sending address. Latest spec is available here: https://github.com/ethanmackie/ecash-chat/blob/uat/README.md I will update the monorepo prefix doc separately.