[avalanche] Introduce StakeContenderId
ClosedPublic
Actions

Authored by roqqit on Aug 12 2024, 22:17.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC5ad50cf4eb85: [avalanche] Introduce StakeContenderId

Summary

StakeContenderId will enable the node to poll for potential stake winners (as a new CInv type). This will further enable pre-consensus on staking rewards to ensure that nodes validate the same winner set even if some proofs are missing from some nodes' proof sets.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-id

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29954
Build 59443: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 59442: arc lint + arc unit

Event Timeline

roqqit created this revision.Aug 12 2024, 22:17

Owners added a reviewer: Restricted Owners Package.Aug 12 2024, 22:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2024, 22:17

roqqit requested review of this revision.Aug 12 2024, 22:17

Harbormaster completed remote builds in B29954: Diff 49167.Aug 12 2024, 22:43

Fabien requested changes to this revision.Aug 13 2024, 06:58

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/stakecontender.h
8	remove
9	remove
10	remove
23	Prefer strong typing so we don't do implicit conversions
26	Why using the payout script here instead of the proofid ? proofid is the source of uniqueness

This revision now requires changes to proceed.Aug 13 2024, 06:58

cleanups
strongly type StakeContenderId
switch to blockhash + proofid instead of blockhash + payoutscript since this could be more versatile down the road
streamlined implementation a bit, which eliminated stakecontender.cpp

Fabien accepted this revision.Aug 13 2024, 19:52

Fabien added inline comments.