Page MenuHomePhabricator

Revert "[avalanche] Sort txs to poll by modified fee rate"
ClosedPublic

Authored by Fabien on Aug 13 2024, 14:10.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC77a9534f0e63: Revert "[avalanche] Sort txs to poll by modified fee rate"
Summary

This reverts commit 223c43df3eb5ac6fabed516e7ef34adcbf5f87af.

The sorting algorithm in itself works but is introducing a design issue:
it needs the mempool to be locked to ensure deterministic ordering. But
the lock is only help during a single comparison and not during the whole
sorting which can lead to issues. Holding the lock at callsite is not
really doable because of the std::variant, or would be cause a huge
performance hit.

For now let's revert this and keep it simple by always sorting by txid.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable