Differential D16642

[e.cash] Move button ID down
ClosedPublic
Actions

Authored by johnkuney on Aug 13 2024, 21:06.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC4cb55fd9cdae: [e.cash] Move button ID down

Summary

The CSS Id needs to be on the link for Google tag manager to pick it up on click
This will allow us to track very specific buttons, as opposed to any clicks on x link

Test Plan

preview the site and check the button id on hero landing

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-movebuttonid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29974
Build 59482: Build Diff
Build 59481: arc lint + arc unit

Event Timeline

johnkuney created this revision.Aug 13 2024, 21:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 13 2024, 21:06

johnkuney requested review of this revision.Aug 13 2024, 21:06

Harbormaster completed remote builds in B29974: Diff 49198.Aug 13 2024, 21:06

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41495 for the next 60 minutes.

bytesofman accepted this revision.Aug 13 2024, 22:07

This revision is now accepted and ready to land.Aug 13 2024, 22:07

Closed by commit rABC4cb55fd9cdae: [e.cash] Move button ID down (authored by johnkuney). · Explain WhyAug 13 2024, 22:25

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC4cb55fd9cdae: [e.cash] Move button ID down.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

button/

index.js

3 lines

Diff 49198

View Options

web/e.cash/components/button/index.js

[e.cash] Move button ID downClosedPublicActions