Page MenuHomePhabricator
Differential D16683

[explorer] Remove extra spaces around 's'
ClosedPublic
Actions

Authored by johnkuney on Tue, Aug 27, 03:48.

Details

Reviewers
PiRK
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABCa3125926c643: [explorer] Remove extra spaces around 's'
Summary

on a transaciton page, in the block row under general details, the 's' in confirmations has a space either side
This came from the line break from the new formatting

Test Plan

preview the site and check the space is no longer there

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

johnkuney created this revision.Tue, Aug 27, 03:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Aug 27, 03:48
johnkuney requested review of this revision.Tue, Aug 27, 03:48
Harbormaster completed remote builds in B30091: Diff 49361.Tue, Aug 27, 03:48
johnkuney planned changes to this revision.Tue, Aug 27, 03:49
johnkuney updated this revision to Diff 49362.Tue, Aug 27, 03:57

fix spacing

Harbormaster completed remote builds in B30092: Diff 49362.Tue, Aug 27, 03:57
PiRK added a subscriber: PiRK.Tue, Aug 27, 13:12
PiRK added inline comments.
web/explorer/explorer-server/templates/pages/transaction.html
134 ↗(On Diff #49362)

What does the dash do? Is there a link to some doc about this somewhere?
It seems like it is freaking out the new linter (see extra indentation below)

johnkuney updated this revision to Diff 49372.Tue, Aug 27, 15:36

adjust -

Harbormaster completed remote builds in B30102: Diff 49372.Tue, Aug 27, 15:36
johnkuney updated this revision to Diff 49373.Tue, Aug 27, 15:39

formatting

Harbormaster completed remote builds in B30103: Diff 49373.Tue, Aug 27, 15:39
PiRK accepted this revision.Tue, Aug 27, 15:47
This revision is now accepted and ready to land.Tue, Aug 27, 15:47
johnkuney added a comment.Tue, Aug 27, 15:59

actually this is still causing the space after the 's' looks like

Here is some not too helpful doc....https://djc.github.io/askama/configuration.html#whitespace-control

Im having trouble getting it to work and not add a bunch of new formatting to the rest of the page...

johnkuney updated this revision to Diff 49374.Tue, Aug 27, 16:02

fix extra space

Harbormaster completed remote builds in B30104: Diff 49374.Tue, Aug 27, 16:02
johnkuney added a comment.Tue, Aug 27, 16:05

yeah this is the only way I can get it to work, but it tabs everything below it over

johnkuney requested review of this revision.Tue, Aug 27, 16:15
tobias_ruck requested changes to this revision.Tue, Aug 27, 21:21
tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
web/explorer/explorer-server/templates/pages/transaction.html
134 ↗(On Diff #49374)

you can just repeat "confirmation" and not use {%-, which seems to confuse djlint

This revision now requires changes to proceed.Tue, Aug 27, 21:21
johnkuney updated this revision to Diff 49395.Wed, Aug 28, 18:15

fix spacing issue and avoid extra formatting

Harbormaster completed remote builds in B30118: Diff 49395.Wed, Aug 28, 18:15
johnkuney added a comment.Wed, Aug 28, 18:17

good call thanks, had to add the closing ) in each one as well

tobias_ruck accepted this revision.Wed, Aug 28, 19:24

Works for me 👍🏻

Maybe in the future we can fix the formatter and simplify this again

This revision is now accepted and ready to land.Wed, Aug 28, 19:24
Closed by commit rABCa3125926c643: [explorer] Remove extra spaces around 's' (authored by johnkuney). · Explain WhyWed, Aug 28, 19:55
This revision was automatically updated to reflect the committed changes.
johnkuney added a commit: rABCa3125926c643: [explorer] Remove extra spaces around 's'.

Revision Contents
Changeset List

PathSize
web/
explorer/
explorer-server/
templates/
pages/
8 lines

Diff 49397

View Options

web/explorer/explorer-server/templates/pages/transaction.html

Loading...