Paths

Table of Contentst

Differential D16688

tests: fix formatting of itemid in p2p_inv_download
ClosedPublic
Actions

Authored by PiRK on Wed, Aug 28, 09:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download

Summary

This new test added in D16668 caused intermittent failures when the itemid hex representation started with a 0

AssertionError: [node 0] Expected messages "['received getdata (1 invsz)', 'received getdata for: 0x1f000002 8cbfe7dca09271f2d028790ae71770b1b4a6263e88fa0bf9e29ab118be195ea']" does not partially match log:

    - 2024-08-27T20:02:23.029782Z [../../src/net_processing.cpp:5330] [ProcessMessage] received getdata for: 0x1f000002 08cbfe7dca09271f2d028790ae71770b1b4a6263e88fa0bf9e29ab118be195ea peer=1

Use the uint256_hex helper function to properly format the inv id.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Aug 28, 09:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 28, 09:11

PiRK requested review of this revision.Wed, Aug 28, 09:11

PiRK edited the summary of this revision. (Show Details)Wed, Aug 28, 09:12

Harbormaster completed remote builds in B30114: Diff 49390.Wed, Aug 28, 09:38

roqqit accepted this revision.Wed, Aug 28, 16:48

This revision is now accepted and ready to land.Wed, Aug 28, 16:48

Closed by commit rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download (authored by PiRK). · Explain WhyWed, Aug 28, 17:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_inv_download.py

2 lines

Diff 49394

test/functional/p2p_inv_download.py

Loading...