Page MenuHomePhabricator
Differential D16668

[avalanche] Add stake contender inv type
ClosedPublic
Actions

Authored by roqqit on Tue, Aug 20, 16:41.

Details

Reviewers
PiRK
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCf93c6792c0cf: [avalanche] Add stake contender inv type
Summary

This patch adds the stake contender inv type as a necessary precursor to finalizing stake winners in pre-consensus. This inv type is not actually requestable, so it is ignored. It will be used to poll for stake winners in a future patch.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

roqqit created this revision.Tue, Aug 20, 16:41
Owners added a reviewer: Restricted Owners Package.Tue, Aug 20, 16:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Aug 20, 16:41
roqqit requested review of this revision.Tue, Aug 20, 16:41
Harbormaster completed remote builds in B30042: Diff 49296.Tue, Aug 20, 17:10
PiRK accepted this revision.Wed, Aug 21, 12:53
PiRK added a subscriber: PiRK.

with a nit in the test

test/functional/p2p_inv_download.py
491–492 ↗(On Diff #49296)

You can use a named arg rather than adding a comment (see p2p_filter.py for an example)

This revision is now accepted and ready to land.Wed, Aug 21, 12:53
roqqit updated this revision to Diff 49308.Wed, Aug 21, 19:03

use named arg per feedback

Harbormaster completed remote builds in B30051: Diff 49308.Wed, Aug 21, 19:33
Closed by commit rABCf93c6792c0cf: [avalanche] Add stake contender inv type (authored by roqqit). · Explain WhyThu, Aug 22, 15:33
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABCf93c6792c0cf: [avalanche] Add stake contender inv type.
PiRK mentioned this in D16688: tests: fix formatting of itemid in p2p_inv_download.Wed, Aug 28, 09:11
PiRK mentioned this in rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download.Wed, Aug 28, 17:53

Revision Contents
Changeset List

PathSize
src/
13 lines
5 lines
test/
functional/
52 lines
test_framework/
2 lines

Diff 49330

View Options

src/net_processing.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

test/functional/p2p_inv_download.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...