Differential D16668

[avalanche] Add stake contender inv type
ClosedPublic
Actions

Authored by roqqit on Aug 20 2024, 16:41.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCf93c6792c0cf: [avalanche] Add stake contender inv type

Summary

This patch adds the stake contender inv type as a necessary precursor to finalizing stake winners in pre-consensus. This inv type is not actually requestable, so it is ignored. It will be used to poll for stake winners in a future patch.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-msg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30042
Build 59618: Build Diff	build-debug · lint-circular-dependencies · build-clang-tidy · build-clang · build-without-wallet · build-diff
Build 59617: arc lint + arc unit

Event Timeline

roqqit created this revision.Aug 20 2024, 16:41

Owners added a reviewer: Restricted Owners Package.Aug 20 2024, 16:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 20 2024, 16:41

roqqit requested review of this revision.Aug 20 2024, 16:41

Harbormaster completed remote builds in B30042: Diff 49296.Aug 20 2024, 17:10

with a nit in the test

test/functional/p2p_inv_download.py
491–492	You can use a named arg rather than adding a comment (see p2p_filter.py for an example)

This revision is now accepted and ready to land.Aug 21 2024, 12:53

use named arg per feedback

Harbormaster completed remote builds in B30051: Diff 49308.Aug 21 2024, 19:33

Closed by commit rABCf93c6792c0cf: [avalanche] Add stake contender inv type (authored by roqqit). · Explain WhyAug 22 2024, 15:33

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCf93c6792c0cf: [avalanche] Add stake contender inv type.

PiRK mentioned this in D16688: tests: fix formatting of itemid in p2p_inv_download.Aug 28 2024, 09:11

PiRK mentioned this in rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download.Aug 28 2024, 17:53

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

13 lines

5 lines

test/

functional/

p2p_inv_download.py

53 lines

test_framework/

2 lines

Diff 49296

src/net_processing.cpp

Loading...

src/protocol.h

Loading...

test/functional/p2p_inv_download.py

Loading...

test/functional/test_framework/messages.py

Loading...