Page MenuHomePhabricator

[e.cash] Swap color cashtab logos
ClosedPublic

Authored by johnkuney on Aug 29 2024, 16:55.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC247f9514753f: [e.cash] Swap color cashtab logos
Summary

All wallet logos are white on /wallets except Cashtab
Rreplacing with white versions for consistency

Test Plan

preview the site and check /wallets

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecashwalletlogos
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30131
Build 59795: Build Diff
Build 59794: arc lint + arc unit

Event Timeline

image.png (560×960 px, 84 KB)

would be nice if both of these images took up 100% of the tile width -- but that is already not happening with the current images. This is an improvement.

This revision is now accepted and ready to land.Aug 29 2024, 23:35

Yeah since all the logos are different aspects, they have a fixed height and the widths can vary.
Could make it a fixed width but then the heights will vary (and it wouldn't look right since would move the top line of the text)
Best option probably would be to pick a size and fit each logo in it with extra whitespace as needed/looks balanced

This revision was automatically updated to reflect the committed changes.