Differential D16693

[e.cash] Swap color cashtab logos
ClosedPublic
Actions

Authored by johnkuney on Aug 29 2024, 16:55.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC247f9514753f: [e.cash] Swap color cashtab logos

Summary

All wallet logos are white on /wallets except Cashtab
Rreplacing with white versions for consistency

Test Plan

preview the site and check /wallets

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecashwalletlogos

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 30131
Build 59795: Build Diff
Build 59794: arc lint + arc unit

Event Timeline

johnkuney created this revision.Aug 29 2024, 16:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 29 2024, 16:55

johnkuney requested review of this revision.Aug 29 2024, 16:55

Harbormaster completed remote builds in B30131: Diff 49411.Aug 29 2024, 16:55

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41990 for the next 60 minutes.

would be nice if both of these images took up 100% of the tile width -- but that is already not happening with the current images. This is an improvement.

This revision is now accepted and ready to land.Aug 29 2024, 23:35

Yeah since all the logos are different aspects, they have a fixed height and the widths can vary.
Could make it a fixed width but then the heights will vary (and it wouldn't look right since would move the top line of the text)
Best option probably would be to pick a size and fit each logo in it with extra whitespace as needed/looks balanced

Closed by commit rABC247f9514753f: [e.cash] Swap color cashtab logos (authored by johnkuney). · Explain WhyAug 30 2024, 16:29

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC247f9514753f: [e.cash] Swap color cashtab logos.