[Chronik] Make `ffi::CBlockIndex` `Sync`
ClosedPublic
Actions

Authored by tobias_ruck on Wed, Sep 11, 14:15.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC92143f7e31ff: [Chronik] Make `ffi::CBlockIndex` `Sync`

Summary

&CBlockIndex can be shared between threads safely, so it is sound to make CBlockIndex implement Sync.

Currently async code using CBlockIndex can't hold a & reference between await points, but actually this is fine, so we allow it.

There's no change in behavior.

Test Plan

cargo check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Wed, Sep 11, 14:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 11, 14:15

tobias_ruck requested review of this revision.Wed, Sep 11, 14:15

PiRK accepted this revision.Wed, Sep 11, 14:18

PiRK added a subscriber: PiRK.

PiRK added inline comments.

chronik/chronik-bridge/src/ffi.rs
356 ↗	(On Diff #49589)

This revision is now accepted and ready to land.Wed, Sep 11, 14:18

Harbormaster completed remote builds in B30252: Diff 49589.Wed, Sep 11, 14:42

Closed by commit rABC92143f7e31ff: [Chronik] Make `ffi::CBlockIndex` `Sync` (authored by tobias_ruck). · Explain WhyWed, Sep 11, 15:16

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC92143f7e31ff: [Chronik] Make `ffi::CBlockIndex` `Sync`.

PiRK mentioned this in D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.Wed, Sep 11, 15:17

Revision Contents
Changeset List

Path

Size

chronik/

chronik-bridge/

src/

ffi.rs

4 lines

Diff 49594

View Options

chronik/chronik-bridge/src/ffi.rs

[Chronik] Make `ffi::CBlockIndex` `Sync`ClosedPublicActions