Differential D16748

[e.cash] Fix video background not showing
ClosedPublic
Actions

Authored by johnkuney on Sep 11 2024, 17:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa7586c97f13c: [e.cash] Fix video background not showing

Summary

on subpages such as /core-tech or /roadmap the blue video background in the top section was hidden due to a css issue
Addings some z-index adjustments so it works on subpages and the landing page

Test Plan

preview the site and check the video background looks good

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-fixzindex

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30258
Build 60043: Build Diff
Build 60042: arc lint + arc unit

Event Timeline

johnkuney created this revision.Sep 11 2024, 17:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2024, 17:29

johnkuney requested review of this revision.Sep 11 2024, 17:29

Harbormaster completed remote builds in B30258: Diff 49596.Sep 11 2024, 17:29

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41550 for the next 60 minutes.

Crazy this went unnoticed for so long

This revision is now accepted and ready to land.Sep 11 2024, 20:15

Closed by commit rABCa7586c97f13c: [e.cash] Fix video background not showing (authored by johnkuney). · Explain WhySep 11 2024, 20:55

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCa7586c97f13c: [e.cash] Fix video background not showing.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

videobackground/

styles.js

2 lines

styles/

pages/

homepage.js

1 line

Diff 49596

View Options

web/e.cash/components/videobackground/styles.js