[avalanche] Implement cleanup for stake contender cache
Needs RevisionPublic
Actions

Authored by roqqit on Wed, Sep 18, 16:24.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

The stake contender cache needs a way to be cleaned up so that it does not grow unbounded. The intent is to call cleanup() when a block becomes newly finalized since there is no need to maintain the cache for finalized blocks.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30347
Build 60219: Build Diff	build-without-wallet · build-debug · lint-circular-dependencies · build-clang-tidy · build-clang · build-diff
Build 60218: arc lint + arc unit

Event Timeline

roqqit created this revision.Wed, Sep 18, 16:24

Owners added a reviewer: Restricted Owners Package.Wed, Sep 18, 16:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 18, 16:24

roqqit requested review of this revision.Wed, Sep 18, 16:24

Harbormaster completed remote builds in B30347: Diff 49715.Wed, Sep 18, 16:47

Fabien requested changes to this revision.Wed, Sep 18, 19:05

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/stakecontendercache.cpp
27	I think you can make this more effective and not require cs_main by adding the block height to the cache. Manual winners could also be made a multi index to achieve the same

This revision now requires changes to proceed.Wed, Sep 18, 19:05