[avalanche] Check unknown inv type in cooldown test
ClosedPublic
Actions

Authored by roqqit on Sep 25 2024, 18:44.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC30c59afc75a5: [avalanche] Check unknown inv type in cooldown test

Summary

Make sure unknown inv types cooldown just like known types do.

Depends on D16813

Test Plan

test_runner.py abc_p2p_avalanche_cooldown

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cooldown-unknown

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30423
Build 60366: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 60365: arc lint + arc unit

Event Timeline

roqqit created this revision.Sep 25 2024, 18:44

Owners added a reviewer: Restricted Owners Package.Sep 25 2024, 18:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2024, 18:44

roqqit requested review of this revision.Sep 25 2024, 18:44

Harbormaster completed remote builds in B30420: Diff 49829.Sep 25 2024, 19:03

Fabien requested changes to this revision.Sep 25 2024, 20:18

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/abc_p2p_avalanche_cooldown.py
109 ↗	(On Diff #49829)	You should add UNDEFINED as a constant in messages.py, so it mirrors protocol.h (and makes it clear 0 is an invalid inv type)

This revision now requires changes to proceed.Sep 25 2024, 20:18

add MSG_UNDEFINED constant

Harbormaster completed remote builds in B30423: Diff 49834.Sep 26 2024, 17:05

Fabien accepted this revision.Sep 26 2024, 18:52

This revision is now accepted and ready to land.Sep 26 2024, 18:52

Closed by commit rABC30c59afc75a5: [avalanche] Check unknown inv type in cooldown test (authored by roqqit). · Explain WhySep 26 2024, 19:31

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC30c59afc75a5: [avalanche] Check unknown inv type in cooldown test.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_cooldown.py

32 lines

test_framework/

messages.py

3 lines

Diff 49834

View Options

test/functional/abc_p2p_avalanche_cooldown.py