[iguana] make some includes explicit
ClosedPublic
Actions

Authored by PiRK on Sep 30 2024, 10:57.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2f05fb34dbdf: [iguana] make some includes explicit

Summary

string, vector and ScriptError were included transitively via interpreter.h, but for me optional was missing and causing a compile error.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2024, 10:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2024, 10:57

PiRK requested review of this revision.Sep 30 2024, 10:57

make sure script_error.h is included directly in the .cpp

Fabien accepted this revision.Sep 30 2024, 11:22

This revision is now accepted and ready to land.Sep 30 2024, 11:22

This revision was landed with ongoing or failed builds.Sep 30 2024, 11:23

Closed by commit rABC2f05fb34dbdf: [iguana] make some includes explicit (authored by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC2f05fb34dbdf: [iguana] make some includes explicit.

Harbormaster completed remote builds in B30434: Diff 49851.Sep 30 2024, 11:25

Harbormaster completed remote builds in B30435: Diff 49852.Sep 30 2024, 11:33

Revision Contents
Changeset List

Path

Size

src/

iguana/

iguana_interpreter.h

6 lines

iguana_interpreter.cpp

1 line

Diff 49853

View Options

src/iguana/iguana_interpreter.h