Page MenuHomePhabricator

build: set --build when configuring packages in depends
ClosedPublic

Authored by Fabien on Oct 17 2024, 16:00.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABC145c59a49752: build: set --build when configuring packages in depends
Summary
After reading
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/autoconf.html#Specifying-Target-Triplets,
my understanding is that this change should mostly be a no-op, as
--build defaults to the output of config.guess, however, this may be
slightly more correct
>  For historical reasons, whenever you specify --host, be sure to
> specify --build too; this will be fixed in the future.

and will quell some warnings in depends (#16354). If anything, this
also explicitly enables cross-compilation mode when `--host` differs
from `--build`.

As for "fixed in the future", this is the case for Autoconf 2.70+.

Backport of core#21403.

Test Plan

Run the guix builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR21403
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30632
Build 60780: Build Diff
Build 60779: arc lint + arc unit