Page MenuHomePhabricator

[ecash-agora] ts linting in agora.ts
ClosedPublic

Authored by bytesofman on Oct 18 2024, 11:07.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC3f56be995c7c: [ecash-agora] ts linting in agora.ts
Summary

typescript does not like while (true). Apparently this is the "right way" to "do something forever"

https://eslint.org/docs/latest/rules/no-constant-condition

use const instead of let for a constant

Test Plan

npm test and CI

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman retitled this revision from [ecash-agora] correct while (true) ts error to [ecash-agora] ts linting in agora.ts.Oct 18 2024, 11:12
bytesofman edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 18 2024, 13:05
This revision was automatically updated to reflect the committed changes.