Differential D16947

[cmake] Remove redundant find_package(Python)
ClosedPublic
Actions

Authored by Fabien on Oct 21 2024, 16:09.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python)

Summary

These calls are no-op because the FindPython for the interpreter is already called in the main CMakeLists.txt (and the variable is cached). Also these calls don't make it mandatory nor enforce a minimum version which is confusing.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 21 2024, 16:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2024, 16:09

Python3_EXECUTABLE => Python_EXECUTABLE

Harbormaster completed remote builds in B30705: Diff 50243.Oct 21 2024, 17:06

Harbormaster completed remote builds in B30706: Diff 50244.Oct 21 2024, 17:10

PiRK accepted this revision.Oct 21 2024, 19:11

This revision is now accepted and ready to land.Oct 21 2024, 19:11

Closed by commit rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python) (authored by Fabien). · Explain WhyOct 21 2024, 19:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python).

Revision Contents
Changeset List

Path

Size

cmake/

modules/

Coverage.cmake

3 lines

src/

iguana/

CMakeLists.txt

2 lines

Diff 50253

View Options

cmake/modules/Coverage.cmake