Differential D16976

[faucet] Allow to retry upon request failure
ClosedPublic
Actions

Authored by Fabien on Thu, Oct 24, 08:05.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC9856864d5e0e: [faucet] Allow to retry upon request failure

Summary

The actual IP rate limit will prevent a failed request from being retried until the window (default 24h) expired. There are circumstances where this is not desirable, e.g. if the user had a typo in the address and validation failed. We only want to allow 1 successful request per day so let's do exactly that.

Test Plan

Read the doc for this option: https://express-rate-limit.mintlify.app/reference/configuration#skipfailedrequests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, Oct 24, 08:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 24, 08:05

Fabien requested review of this revision.Thu, Oct 24, 08:05

Harbormaster completed remote builds in B30795: Diff 50361.Thu, Oct 24, 08:05

PiRK accepted this revision.Thu, Oct 24, 13:31

This revision is now accepted and ready to land.Thu, Oct 24, 13:31

Closed by commit rABC9856864d5e0e: [faucet] Allow to retry upon request failure (authored by Fabien). · Explain WhyThu, Oct 24, 13:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9856864d5e0e: [faucet] Allow to retry upon request failure.

Revision Contents
Changeset List

Path

Size

apps/

faucet/

1 line

Diff 50387

apps/faucet/index.ts

Loading...