[ecash-herald + token-server] Update typescript and docker build settings
ClosedPublic
Actions

Authored by bytesofman on Nov 3 2024, 12:41.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCba63229e2b34: [ecash-herald + token-server] Update typescript and docker build settings

Summary

These apps are on a similar stack and seeing similar failures in CI.

I am not sure about the ecash-lib build related failure they are both now seeing in CI, but, since it happened after both added the "exclude: node_modules/" setting, I am removing this. Typescript does this by default, potentially it is interfering with other dependencies.

Add tsconfig.build.json so that we do not build the test files.

ecash-herald needs mock-chronik-client as this is used in scripts. Maybe we do not need to build scripts but they could be useful on the server.

Test Plan

docker build -f ecash-herald.Dockerfile -t ecash-herald_local .
docker build -f token-server.Dockerfile -t token-server_local .

local builds pass, but I have not managed to repeat the failure currently seen in CI

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 3 2024, 12:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 3 2024, 12:41

lint

bytesofman retitled this revision from [token-server] Update typescript build settings for ecash-herald and token-server to [ecash-herald + token-server] Update typescript and docker build settings.Nov 3 2024, 12:44

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B30978: Diff 50630.Nov 3 2024, 12:48

Harbormaster completed remote builds in B30979: Diff 50631.Nov 3 2024, 12:50

bytesofman published this revision for review.Nov 3 2024, 12:53

emack accepted this revision.Nov 4 2024, 00:51

emack added a subscriber: emack.

emack added inline comments.

apps/token-server/tsconfig.json
10 ↗	(On Diff #50631)	Based on what I've read, setting this flag to true normally fixes this issue for a lot of people online, but you already have it set to true.