Paths

Table of Contentst

Differential D1709

Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2018, 14:43.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc6af1b0228db: Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI
rABCc6af1b0228db: Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 4 2018, 14:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2018, 14:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3179: Diff 4739.Sep 4 2018, 15:22

jasonbcox accepted this revision.Sep 4 2018, 17:33

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/rpc_tests.cpp
245 ↗	(On Diff #4739)	The below line is shorter and nicer to read as just `SATOSHI`. Do you think it makes sense to add `ZERO_SATOSHI` or `ZERO_AMOUNT` as a constant?

This revision is now accepted and ready to land.Sep 4 2018, 17:33

deadalnix added inline comments.Sep 4 2018, 17:42

src/test/rpc_tests.cpp
245 ↗	(On Diff #4739)	Maybe. It's easy to add a constant for this.

Closed by commit rABCc6af1b0228db: Amount(0LL) => Amount::zero() and Amount(1LL) => SATOSHI (authored by deadalnix). · Explain WhySep 4 2018, 17:45

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

mempool_tests.cpp

14 lines

13 lines

Diff 4750

src/test/mempool_tests.cpp

Loading...

src/test/rpc_tests.cpp

Loading...