Paths

Table of Contentst

Differential D17107

net: keep reference to each node during socket wait
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 11, 19:00.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC32e377f69f42: net: keep reference to each node during socket wait

Summary

Create the snapshot of CConnman::vNodes to operate on earlier in
CConnman::SocketHandler(), before calling CConnman::SocketEvents()
and pass the vNodes copy from the snapshot to SocketEvents().

This will keep the refcount of each node incremented during
SocketEvents() so that the CNode object is not destroyed before
SocketEvents() has finished.

Currently in SocketEvents() we only remember file descriptor numbers
(when not holding CConnman::cs_vNodes) which is safe, but we will
change this to remember pointers to CNode::m_sock.

This is a partial backport of core#21943
https://github.com/bitcoin/bitcoin/pull/21943/commits/664ac22c5379db65757fc3aab91fff8765683e7f
https://github.com/bitcoin/bitcoin/pull/21943/commits/c7eb19ec8302e6a5abd89c0566540c2c862e9121

Depends on D17106

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Nov 11, 19:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 11, 19:00

PiRK requested review of this revision.Mon, Nov 11, 19:00

teamcity edited the summary of this revision. (Show Details)Mon, Nov 11, 19:00

PiRK edited the summary of this revision. (Show Details)Mon, Nov 11, 19:01

PiRK edited the summary of this revision. (Show Details)

PiRK added a child revision: D17108: net: split CConnman::SocketHandler().Mon, Nov 11, 19:04

Harbormaster completed remote builds in B31082: Diff 50776.Mon, Nov 11, 19:22

PiRK planned changes to this revision.Mon, Nov 11, 19:22

rebase

Harbormaster completed remote builds in B31098: Diff 50800.Tue, Nov 12, 18:19

roqqit accepted this revision.Tue, Nov 12, 18:25

This revision is now accepted and ready to land.Tue, Nov 12, 18:25

Closed by commit rABC32e377f69f42: net: keep reference to each node during socket wait (authored by Vasil Dimov <vd@FreeBSD.org>, committed by PiRK). · Explain WhyWed, Nov 13, 17:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC32e377f69f42: net: keep reference to each node during socket wait.

Revision Contents
Changeset List

Path

Size

src/

26 lines

82 lines

Diff 50837

src/net.h

Loading...

src/net.cpp

Loading...