The slide in menu is appearing with some odd spacing and getting cut off on some mobile devices
Adding a few css tweaks to address this by adding scroll if the screen is too short
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC9e7a26de9f03: [cashtab] Menu style tweaks
Preview the site and check the menu
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-menu-edits
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31109 Build 61719: Build Diff cashtab-tests Build 61718: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: <App /> Navigation menu routes to expected components ======
Error: expect(element).toHaveStyle()
- Expected
- max-height: 0;
+ max-height: calc(100vh - 80px);
at Object.toHaveStyle (/work/cashtab/src/components/App/__tests__/App.test.js:252:54)Each failure log is accessible here:
CashTab Unit Tests: <App /> Navigation menu routes to expected components
Comment Actions
Much better than what we have now, should go in.
A couple of issues
- too wide (should contain the longest named item)
- Seems like there are horizontal stripes of transparency, at least at smallest supported mobile width
Comment Actions
ok it's not really the width that's the issue
current cashtab, we have menu titles aligning left, icons right
this diff has everything aligning right
should preserve existing style of titles left, icons right. could make it display:flex with justify-content: space-between