Page MenuHomePhabricator
Differential D17144

[avalanche] Return pending stake contender status when there is no local staking rewards computed
Needs RevisionPublic
Actions

Authored by roqqit on Fri, Nov 15, 18:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Before staking rewards is computed on the local node, we cannot be sure
of our vote on any particular contender. To avoid convergence issues, we
respond with a pending status.

This also makes contender voting slightly more robust in the unexpected event
that staking rewards fails to be computed for a block due to a bug or
otherwise.

Test Plan
ninja check-avalanche

Diff Detail

Event Timeline

roqqit created this revision.Fri, Nov 15, 18:11
Owners added a reviewer: Restricted Owners Package.Fri, Nov 15, 18:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 15, 18:11
roqqit requested review of this revision.Fri, Nov 15, 18:11
roqqit mentioned this in D17121: [avalanche] Add stake contender polling.Fri, Nov 15, 18:13
roqqit added a child revision: D17121: [avalanche] Add stake contender polling.Fri, Nov 15, 18:14
Fabien requested changes to this revision.Fri, Nov 15, 18:14
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/test/processor_tests.cpp
2521

You no longer have an invalid case in this test, it's worth adding it (either here or in a separate diff)

This revision now requires changes to proceed.Fri, Nov 15, 18:14
Harbormaster completed remote builds in B31153: Diff 50874.Fri, Nov 15, 18:36

Revision Contents
Changeset List

Diff 50874

View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/stakecontendercache.h

Loading...
View Options

src/avalanche/stakecontendercache.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/avalanche/test/stakecontendercache_tests.cpp

Loading...