Page MenuHomePhabricator
Differential D17188

[Cashtab] Use available sk and pk rather than deriving from wif and ecc
Needs ReviewPublic
Actions

Authored by bytesofman on Fri, Nov 22, 18:21.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Now that sk and pk are calculated on cashtab startup and saved with the wallet object, we do not have to derive sk from wif and pk from sk

Had to update some more missed legacy types in mocks to implement.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
use-available-sk-pk
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31283
Build 62064: Build Diffcashtab-tests
Build 62063: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Nov 22, 18:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 22, 18:21
Harbormaster completed remote builds in B31283: Diff 51056.Fri, Nov 22, 18:25
bytesofman published this revision for review.Fri, Nov 22, 18:28
bytesofman added inline comments.
cashtab/src/components/Nfts/fixtures/mocks.ts
374

this changes is not directly related to this diff, however

  • We want to convert this file to ts so that we confirm the mocks it contains have sk and pk as expected
  • converting to ts, we need to make everything in the file valid
1542

not sure where this was originally used. it's not used by anything anymore.

removed due to ts lint issues.

cashtab/src/transactions/fixtures/vectors.js
325

this was always a weird test

we were actually just showing that the wif library could not get the private key from a corrupt wif

now we don't use wif

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Agora/
OrderBook/
21 lines
fixtures/
11 lines
40 lines
App/
__tests__/
8 lines
Etokens/
Token/
60 lines
__tests__/
13 lines
Nfts/
__tests__/
32 lines
fixtures/
mocks.ts
mocks.js
86 lines
7 lines
transactions/
__tests__/
6 lines
fixtures/
mocks.ts
mocks.js
482 lines
42 lines
19 lines

Diff 51056

View Options

cashtab/src/components/Agora/OrderBook/index.tsx

Loading...
View Options

cashtab/src/components/Agora/fixtures/mocks.js

Loading...
View Options

cashtab/src/components/Agora/index.tsx

Loading...
View Options

cashtab/src/components/App/__tests__/App.test.js

Loading...
View Options

cashtab/src/components/Etokens/Token/index.tsx

Loading...
View Options

cashtab/src/components/Etokens/__tests__/TokenActions.test.js

Loading...
View Options

cashtab/src/components/Nfts/__tests__/index.test.js

Loading...
View Options

cashtab/src/components/Nfts/fixtures/mocks.js

Loading...
View Options

cashtab/src/components/Nfts/fixtures/mocks.ts

Loading...
View Options

cashtab/src/components/Nfts/index.tsx

Loading...
View Options

cashtab/src/transactions/__tests__/index.test.js

Loading...
View Options

cashtab/src/transactions/fixtures/mocks.js

Loading...
View Options

cashtab/src/transactions/fixtures/mocks.ts

Loading...
View Options

cashtab/src/transactions/fixtures/vectors.js

Loading...
View Options

cashtab/src/transactions/index.js

Loading...