Paths

Table of Contentst

Differential D17188

[Cashtab] Use available sk and pk rather than deriving from wif and ecc
ClosedPublic
Actions

Authored by bytesofman on Nov 22 2024, 18:21.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC8e807f62cd29: [Cashtab] Use available sk and pk rather than deriving from wif and ecc

Summary

Now that sk and pk are calculated on cashtab startup and saved with the wallet object, we do not have to derive sk from wif and pk from sk

Had to update some more missed legacy types in mocks to implement.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Nov 22 2024, 18:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2024, 18:21

Harbormaster completed remote builds in B31283: Diff 51056.Nov 22 2024, 18:25

bytesofman published this revision for review.Nov 22 2024, 18:28

bytesofman added inline comments.

cashtab/src/components/Nfts/fixtures/mocks.ts
374 ↗	(On Diff #51056)	this changes is not directly related to this diff, however We want to convert this file to ts so that we confirm the mocks it contains have sk and pk as expected converting to ts, we need to make everything in the file valid
1542 ↗	(On Diff #51056)	not sure where this was originally used. it's not used by anything anymore. removed due to ts lint issues.
cashtab/src/transactions/fixtures/vectors.js
325 ↗	(On Diff #51056)	this was always a weird test we were actually just showing that the `wif` library could not get the private key from a corrupt wif now we don't use wif

emack accepted this revision.Nov 23 2024, 01:16

This revision is now accepted and ready to land.Nov 23 2024, 01:16

Closed by commit rABC8e807f62cd29: [Cashtab] Use available sk and pk rather than deriving from wif and ecc (authored by bytesofman). · Explain WhyNov 23 2024, 01:28

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC8e807f62cd29: [Cashtab] Use available sk and pk rather than deriving from wif and ecc.

Revision Contents
Changeset List

Path

Size

cashtab/

package-lock.json

4 lines

2 lines

src/

components/

Agora/

OrderBook/

21 lines

fixtures/

11 lines

40 lines

App/

__tests__/

8 lines

Etokens/

Token/

60 lines

__tests__/

TokenActions.test.js

13 lines

Nfts/

__tests__/

32 lines

fixtures/

	mocks.ts
	mocks.js

86 lines

7 lines

transactions/

__tests__/

6 lines

fixtures/

	mocks.ts
	mocks.js

482 lines

42 lines

19 lines

Diff 51065

cashtab/package-lock.json

Loading...

cashtab/package.json

Loading...

cashtab/src/components/Agora/OrderBook/index.tsx

Loading...

cashtab/src/components/Agora/fixtures/mocks.js

Loading...

cashtab/src/components/Agora/index.tsx

Loading...

cashtab/src/components/App/tests/App.test.js

Loading...

cashtab/src/components/Etokens/Token/index.tsx

Loading...

cashtab/src/components/Etokens/tests/TokenActions.test.js

Loading...

cashtab/src/components/Nfts/tests/index.test.js

Loading...

cashtab/src/components/Nfts/fixtures/mocks.js

Loading...

cashtab/src/components/Nfts/fixtures/mocks.ts

Loading...

cashtab/src/components/Nfts/index.tsx

Loading...

cashtab/src/transactions/tests/index.test.js

Loading...

cashtab/src/transactions/fixtures/mocks.js

Loading...

cashtab/src/transactions/fixtures/mocks.ts

Loading...

cashtab/src/transactions/fixtures/vectors.js

Loading...

cashtab/src/transactions/index.js

Loading...