[Cashtab] Stop showing [object Object] on agora offers yet to populate token cache info
ClosedPublic
Actions

Authored by bytesofman on Sun, Dec 1, 06:29.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCc7a97de863e8: [Cashtab] Stop showing [object Object] on agora offers yet to populate token…

Summary

We want to show an inline loader in this case. Current code is stringifying inline loaders inside a link.

Add a condition to show the loader instead of the stringified loader as link.

Test Plan

npm test, see screenshot

before:

after:

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sun, Dec 1, 06:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Dec 1, 06:29

bytesofman edited the test plan for this revision. (Show Details)Sun, Dec 1, 06:29

bytesofman retitled this revision from [Cashtab] Stop showing [Loading loading] object on agora offers yet to populate token cache info to [Cashtab] Stop showing [Object Object] on agora offers yet to populate token cache info.Sun, Dec 1, 06:33

Harbormaster completed remote builds in B31462: Diff 51312.Sun, Dec 1, 06:33

bytesofman published this revision for review.Sun, Dec 1, 06:33

bytesofman retitled this revision from [Cashtab] Stop showing [Object Object] on agora offers yet to populate token cache info to [Cashtab] Stop showing [object Object] on agora offers yet to populate token cache info.

emack accepted this revision.Sun, Dec 1, 14:03

This revision is now accepted and ready to land.Sun, Dec 1, 14:03

Closed by commit rABCc7a97de863e8: [Cashtab] Stop showing [object Object] on agora offers yet to populate token… (authored by bytesofman). · Explain WhySun, Dec 1, 14:11

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc7a97de863e8: [Cashtab] Stop showing [object Object] on agora offers yet to populate token….