Paths

Table of Contentst

Differential D17271

[Cashtab] Make agora tiles more useful
AcceptedPublic
Actions

Authored by bytesofman on Sun, Dec 1, 14:08.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Summary

Diff does 2 things bc they both are important to improving UX around increasing number of agora offers.

We include a displayed abbreviated tokenId and a copy tokenId button. This can help users distinguish between attempted scams.
We change the link to open the token page of an agora offer in Cashtab, which shows the offer and more info about the token, instead of the block explorer which does not really show much at all

Test Plan

npm test, review screenshot

before

after

Diff Detail

Repository

rABC Bitcoin ABC

Branch

token-id-back-in-agora

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31468
Build 62434: Build Diff	cashtab-tests
Build 62433: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sun, Dec 1, 14:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Dec 1, 14:08

bytesofman edited the test plan for this revision. (Show Details)Sun, Dec 1, 14:09

remove unneeded <><>

Harbormaster completed remote builds in B31466: Diff 51316.Sun, Dec 1, 14:12

rebase

Harbormaster completed remote builds in B31467: Diff 51317.Sun, Dec 1, 14:14

Harbormaster completed remote builds in B31468: Diff 51319.Sun, Dec 1, 14:17

bytesofman published this revision for review.Sun, Dec 1, 14:25

emack requested changes to this revision.Mon, Dec 2, 00:12

emack added a subscriber: emack.

emack added inline comments.

cashtab/src/components/Agora/OrderBook/index.tsx
733	shouldn't this break the order book rendering tests?

This revision now requires changes to proceed.Mon, Dec 2, 00:12

bytesofman requested review of this revision.Mon, Dec 2, 02:28

bytesofman marked an inline comment as done.

bytesofman added inline comments.

cashtab/src/components/Agora/OrderBook/index.tsx
733	confirmed by CI it does not The rendering tests are not asserting the URL of this link, only the title. We could test the URL but at that point really getting into the weeds. We don't expect, for example, React to render a link differently from what the code is specified. No real reason to test it unless the link itself changes conditionally.

emack accepted this revision.Mon, Dec 2, 06:14

This revision is now accepted and ready to land.Mon, Dec 2, 06:14

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Agora/

OrderBook/

index.tsx

33 lines

Common/

Atoms.tsx

33 lines

Diff 51319

View Options

cashtab/src/components/Agora/OrderBook/index.tsx