Page MenuHomePhabricator

[Cashtab] Standardize mnemonic validation error msg
ClosedPublic

Authored by bytesofman on Tue, Dec 3, 04:35.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCd5727369b286: [Cashtab] Standardize mnemonic validation error msg
Summary

Some mobile devices can capitalize the first word of a seed when it is typed in.

We prevented this with "type="email"" before but lost that when we upgraded the inputs.

Restore the prevention and improve the validation phrase.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman published this revision for review.Tue, Dec 3, 04:55

Tail of the build log:

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 1s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1487 packages, and audited 3333 packages in 24s

323 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (2 moderate, 2 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@3.2.2 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2741: Property 'type' is missing in type '{ placeholder: string; name: string; value: string; error: string | false; handleInput: (e: ChangeEvent<HTMLInputElement>) => void; }' but required in type 'ModalInputProps'.
    2055 |                             height={250}
    2056 |                         >
  > 2057 |                             <ModalInput
         |                              ^^^^^^^^^^
    2058 |                                 placeholder={`Type "burn ${tokenTicker}" to confirm`}
    2059 |                                 name="etokenToBeBurnt"
    2060 |                                 value={confirmationOfEtokenToBeBurnt}


Build cashtab-tests failed with exit code 1
This revision is now accepted and ready to land.Tue, Dec 3, 07:32