[seeder] Bump thread stacksize
ClosedPublic
Actions

Authored by roqqit on Fri, Dec 13, 20:08.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC61b79c87cb21: [seeder] Bump thread stacksize

Summary

0x20000 is too small on some systems, causing pthread_create() to fail. It turns out that predicting the right value is not trivial, so we can just bump it slightly instead.

Depends on D17348, but only to discover the issue in the first place.

Test Plan

Supposedly setting ulimit -s or ulimit -Hs would allow you to reproduce, but this does not appear to work. If you have a borked environment that is enforcing large stack sizes, just run the seeder:

./bitcoin-seeder

Without the patch it can break. With the patch, it works.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

seeder-thread-stacksize

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31642
Build 62781: Build Diff	lint-circular-dependencies · build-debug · build-clang-tidy · build-clang · build-diff · build-without-wallet
Build 62780: arc lint + arc unit

Event Timeline

roqqit created this revision.Fri, Dec 13, 20:08

Owners added a reviewer: Restricted Owners Package.Fri, Dec 13, 20:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 13, 20:08

roqqit requested review of this revision.Fri, Dec 13, 20:08

roqqit planned changes to this revision.Fri, Dec 13, 20:08

Harbormaster completed remote builds in B31642: Diff 51575.Fri, Dec 13, 20:22

roqqit requested review of this revision.Fri, Dec 13, 20:26

roqqit edited the test plan for this revision. (Show Details)

• redball4az added a subscriber: • redball4az.Sat, Dec 14, 07:31

This comment was removed by Fabien.

Fabien added a subscriber: Fabien.Mon, Dec 16, 09:08

Fabien requested changes to this revision.Mon, Dec 16, 09:15

Fabien added inline comments.

src/seeder/main.cpp
460	We discussed this offline, I don't think this is doing what you expect, according to the doc (https://www.man7.org/linux/man-pages/man3/pthread_attr_setstacksize.3.html) the thread stack is not related to RLIMIT_STACK. Also at the very least you need to check the return code from that function. It might just not work and you will never know.

This revision now requires changes to proceed.Mon, Dec 16, 09:15

Just bump the value because predicting it is proving to be difficult and time consuming

roqqit retitled this revision from [seeder] Respect resource limit for stacksize as set by the system to [seeder] Bump thread stacksize.Tue, Dec 17, 20:38

roqqit edited the summary of this revision. (Show Details)

Fabien accepted this revision.Tue, Dec 17, 20:46

This revision is now accepted and ready to land.Tue, Dec 17, 20:46

Harbormaster completed remote builds in B31701: Diff 51653.Tue, Dec 17, 20:58

Closed by commit rABC61b79c87cb21: [seeder] Bump thread stacksize (authored by roqqit). · Explain WhyTue, Dec 17, 21:02

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC61b79c87cb21: [seeder] Bump thread stacksize.