Page MenuHomePhabricator
Differential D17368

Fix race to check chaintips in p2p_headers_sync_with_minchainwork
Needs RevisionPublic
Actions

Authored by roqqit on Tue, Dec 17, 22:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

node3 is not guaranteed to have finished syncing headers by the time getchaintips is first called.

Test Plan
./test/functional/test_runner.py p2p_headers_sync_with_minchainwork.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
minchainwork-race
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31708
Build 62912: Build Diffbuild-debug · build-clang-tidy · build-clang · build-diff · build-without-wallet
Build 62911: arc lint + arc unit

Event Timeline

roqqit created this revision.Tue, Dec 17, 22:35
Owners added a reviewer: Restricted Owners Package.Tue, Dec 17, 22:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 17, 22:35
roqqit requested review of this revision.Tue, Dec 17, 22:35
Harbormaster completed remote builds in B31708: Diff 51661.Tue, Dec 17, 22:51
Fabien requested changes to this revision.Wed, Dec 18, 08:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/p2p_headers_sync_with_minchainwork.py
68–82

why making this complicated ?

Also I generally don't like overriding the timeout, this creates flaky tests for slow machines.

This revision now requires changes to proceed.Wed, Dec 18, 08:35

Revision Contents
Changeset List

PathSize
test/
functional/
22 lines

Diff 51661

View Options

test/functional/p2p_headers_sync_with_minchainwork.py

Loading...