When a node disconnects, it's connect status is set to false until it's removed from m_nodes in connman.
During this small interval, it is possible for getpeerinfo to report a disconnected node with "connected" as false.
The easiest way to solve this flakiness is to simply wait until getpeerinfo is updated. Calling wait_until is only
necessary immediately after disconnecting a peer, so we do not need to update every check on getpeerinfo in every test.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC7f213483007a: Fix flakiness in tests that wait for peer info to update immediately after…
./test/functional/test_runner.py abc_p2p_avalanche_remote_proofs p2p_addrfetch feature_maxuploadtarget
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- wait-peerinfo-flakiness
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31722 Build 62940: Build Diff build-diff · build-clang-tidy · build-without-wallet · build-clang · build-debug Build 62939: arc lint + arc unit