Differential D17382

test: Avoid intermittent block download timeout in p2p_ibd_stalling
ClosedPublic
Actions

Authored by Fabien on Fri, Dec 20, 22:16.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC5396e280be4c: test: Avoid intermittent block download timeout in p2p_ibd_stalling

Summary

The goal of the test is to check the stalling timeout, not the block download timeout.

On extremely slow hardware (for example qemu virtual hardware), downloading the 1023 blocks may take longer than the block download timeout.

Fix it by pinning the time using mocktime, and only advance it when testing the stalling timeout.

Backport of core#30705.

Test Plan

./test/functional/test_runner.py p2p_ibd_stalling

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Dec 20, 22:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 20, 22:16

Fabien requested review of this revision.Fri, Dec 20, 22:16

teamcity edited the summary of this revision. (Show Details)Fri, Dec 20, 22:16

Harbormaster completed remote builds in B31736: Diff 51707.Fri, Dec 20, 22:33

roqqit accepted this revision.Sat, Dec 21, 02:33

This revision is now accepted and ready to land.Sat, Dec 21, 02:33

Closed by commit rABC5396e280be4c: test: Avoid intermittent block download timeout in p2p_ibd_stalling (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>, committed by Fabien). · Explain WhySat, Dec 21, 14:43

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5396e280be4c: test: Avoid intermittent block download timeout in p2p_ibd_stalling.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_ibd_stalling.py

3 lines

Diff 51709

View Options

test/functional/p2p_ibd_stalling.py

test: Avoid intermittent block download timeout in p2p_ibd_stallingClosedPublicActions