HomePhabricator

test: Avoid intermittent block download timeout in p2p_ibd_stalling

Description

test: Avoid intermittent block download timeout in p2p_ibd_stalling

Summary:

The goal of the test is to check the stalling timeout, not the block download timeout.

On extremely slow hardware (for example qemu virtual hardware), downloading the 1023 blocks may take longer than the block download timeout.

Fix it by pinning the time using mocktime, and only advance it when testing the stalling timeout.

Backport of core#30705.

Test Plan:

./test/functional/test_runner.py p2p_ibd_stalling

Reviewers: #bitcoin_abc, roqqit

Reviewed By: roqqit

Differential Revision: https://reviews.bitcoinabc.org/D17382

Details

Provenance
MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>Authored on Aug 23 2024, 15:50
FabienCommitted on Sat, Dec 21, 14:43
FabienPushed on Sat, Dec 21, 14:43
Reviewer
roqqit
Differential Revision
D17382: test: Avoid intermittent block download timeout in p2p_ibd_stalling
Parents
rABCefbf025838b6: test: Avoid race after connect_nodes
Branches
Unknown
Tags
Unknown
References
HEAD -> master