Differential D17392

Wait for remote proof messages in functional tests
ClosedPublic
Actions

Authored by Fabien on Dec 23 2024, 22:06.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCd64d5e3aa9fd: Wait for remote proof messages in functional tests

Summary

The abc_p2p_avalanche_remote_proofs waits for peers to get properly connected since D17387.
This diff now waits for the messages to be received. This is especially relevant during handshake where the peers can be connected but not completed the avaproof exchange yet on slow machines.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_remote_proofs

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 23 2024, 22:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2024, 22:06

Fabien requested review of this revision.Dec 23 2024, 22:06

Harbormaster completed remote builds in B31750: Diff 51730.Dec 23 2024, 22:06

teamcity added a comment.Dec 23 2024, 22:06

This comment was removed by Fabien.

Revert accidental newline

Harbormaster completed remote builds in B31751: Diff 51731.Dec 23 2024, 22:37

PiRK accepted this revision.Dec 25 2024, 22:32

This revision is now accepted and ready to land.Dec 25 2024, 22:32

teamcity added a comment.Thu, Dec 26, 09:48

This comment was removed by Fabien.

This CI issue appeared with a Teamcity update and has been reported to JetBrains. It causes random failure to fetch the sources which is super annoying

This revision was landed with ongoing or failed builds.Thu, Dec 26, 10:15

Closed by commit rABCd64d5e3aa9fd: Wait for remote proof messages in functional tests (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd64d5e3aa9fd: Wait for remote proof messages in functional tests.