Incremental implementation of ts in Cashtab
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ts-etokens
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31756 Build 63006: Build Diff cashtab-tests Build 63005: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
> ecash-lib@1.2.0 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 2s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1489 packages, and audited 3310 packages in 25s 320 packages are looking for funding run `npm fund` for details 8 vulnerabilities (6 moderate, 2 high) To address issues that do not require attention, run: npm audit fix To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. > cashtab@3.4.4 build > node scripts/build.js Creating an optimized production build... Failed to compile. TS2322: Type '({ tokensKvArray, userLocale }: TokenListProps) => Element[]' is not assignable to type 'FC<TokenListProps>'. Type 'Element[]' is missing the following properties from type 'ReactElement<any, any>': type, props, key [0m [90m 18 |[39m userLocale[33m:[39m string[33m;[39m [90m 19 |[39m } [31m[1m>[22m[39m[90m 20 |[39m [36mconst[39m [33mTokenList[39m[33m:[39m [33mReact[39m[33m.[39m[33mFC[39m[33m<[39m[33mTokenListProps[39m[33m>[39m [33m=[39m ({ tokensKvArray[33m,[39m userLocale }) [33m=>[39m { [90m |[39m [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m [90m 21 |[39m [36mreturn[39m tokensKvArray[33m.[39mmap(keyValueArray [33m=>[39m ( [90m 22 |[39m [33m<[39m[33mTokenLink[39m key[33m=[39m{keyValueArray[[35m0[39m]} to[33m=[39m{[32m`/token/${keyValueArray[0]}`[39m}[33m>[39m [90m 23 |[39m [33m<[39m[33mTokenListItem[39m[0m Build cashtab-tests failed with exit code 1
cashtab/src/components/Etokens/Etokens.tsx | ||
---|---|---|
219–230 | i can't tell if this is a ts lint thing, if not, kinda redundant specifying null |