Part of ongoing effort to convert Cashtab to ts
Convert some small Common components to ts
Decision to include these particular components is arbitrary. Felt like doing just one was too small a diff. Adding any more was too much for one diff.
Differential D17401
[Cashtab] Convert some common components to ts bytesofman on Thu, Dec 26, 18:21. Authored by
Details
Part of ongoing effort to convert Cashtab to ts Convert some small Common components to ts Decision to include these particular components is arbitrary. Felt like doing just one was too small a diff. Adding any more was too much for one diff. npm test
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log: > ecash-lib@1.2.0 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 1s 60 packages are looking for funding run `npm fund` for details 2 vulnerabilities (1 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.2.0 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/b58-ts /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. added 1488 packages, and audited 3309 packages in 24s 320 packages are looking for funding run `npm fund` for details 8 vulnerabilities (6 moderate, 2 high) To address issues that do not require attention, run: npm audit fix To address all issues (including breaking changes), run: npm audit fix --force Run `npm audit` for details. > cashtab@3.4.5 build > node scripts/build.js Creating an optimized production build... Failed to compile. TS2322: Type 'string | null' is not assignable to type 'string'. Type 'null' is not assignable to type 'string'. [0m [90m 2240 |[39m [32m ) : ([39m [90m 2241 |[39m [32m <BalanceHeaderToken[39m [31m[1m>[22m[39m[90m 2242 |[39m [32m formattedDecimalizedTokenBalance={[39m [90m |[39m [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m [90m 2243 |[39m [32m typeof tokenBalance === 'string'[39m [90m 2244 |[39m [32m ? decimalizedTokenQtyToLocaleFormat([39m [90m 2245 |[39m [32m tokenBalance,[39m[0m Build cashtab-tests failed with exit code 1
Comment Actions comment clarifying strange typescript/styled-components interaction
|