Page MenuHomePhabricator
Differential D17411

[Cashtab] Move function only used on Send screen to helpers dir for Send screen
Needs ReviewPublic
Actions

Authored by bytesofman on Fri, Dec 27, 13:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

Almost at the end of long, long effort to get rid of "wtf is this file" cashMethods.js

The last remaining function will go out after ts conversion diffs land

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashmethods-start-out
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31793
Build 63079: Build Diffcashtab-tests
Build 63078: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Dec 27, 13:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 27, 13:36
Harbormaster completed remote builds in B31789: Diff 51775.Fri, Dec 27, 13:39
bytesofman published this revision for review.Fri, Dec 27, 13:41
Fabien requested changes to this revision.Fri, Dec 27, 15:39
Fabien added a subscriber: Fabien.

You should move the doc as well

This revision now requires changes to proceed.Fri, Dec 27, 15:39
bytesofman updated this revision to Diff 51787.Fri, Dec 27, 17:46

move doc, add return type, remove obsolete types from the doc

Harbormaster completed remote builds in B31793: Diff 51787.Fri, Dec 27, 18:16

Revision Contents
Changeset List

PathSize
cashtab/
4 lines
2 lines
src/
components/
Send/
2 lines
helpers/
21 lines
components/
Send/
helpers/
utils/
__tests__/
index.test.ts
cashMethods.test.js
2 lines
utils/
__tests__/
16 lines

Diff 51787

View Options

cashtab/package-lock.json

Loading...
View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Send/SendXec.tsx

Loading...
View Options

cashtab/src/components/Send/helpers/index.test.ts

Loading...
View Options

cashtab/src/components/Send/helpers/index.ts

Loading...
View Options

cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...