Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe2f5b0bdbd81: [cmake] Handle FindBoost.cmake deprecation

Summary

See https://cmake.org/cmake/help/latest/policy/CMP0167.html.

Starting with cmake 3.30 the FindBoost.cmake module is no longer provided and we should use the BoostConfig.cmake provided by Boost. But this file is only available since Boost 1.70.
Work around this by trying the config first then fall back to the module. There are cases where this will fail, e.g. Boost 1.64 (our current minimum) with cmake 3.30 but it's unlikely to have a system with both such a recent cmake and such an old Boost. Also there is no solution to this problem.

Test Plan

ninja check

Run the GUIX builds

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Dec 30, 15:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 30, 15:32

Fabien requested review of this revision.Mon, Dec 30, 15:32

Harbormaster completed remote builds in B31830: Diff 51842.Mon, Dec 30, 15:32

@bot guix-linux guix-osx guix-win

teamcity awarded a token.Mon, Dec 30, 15:37

Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.

Tail of the build log:

-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Failed
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-apple-darwin/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
-- Could NOT find Boost (missing: Boost_DIR)
CMake Error at cmake/modules/NativeExecutable.cmake:47 (cmake_policy):
  Policy "CMP0167" is not known to this version of CMake.
Call Stack (most recent call first):
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1384 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2118 (_Boost_MISSING_DEPENDENCIES)
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2217 (message):
  No header defined for headers; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Error at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: headers) (found suitable version "1.81.0",
  minimum required is "1.64")
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


-- Configuring incomplete, errors occurred!
See also "/bitcoin/source_package/CMakeFiles/CMakeOutput.log".
See also "/bitcoin/source_package/CMakeFiles/CMakeError.log".
Build guix-osx failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.

Tail of the build log:

-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-w64-mingw32/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-w64-mingw32/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
-- Could NOT find Boost (missing: Boost_DIR)
CMake Error at cmake/modules/NativeExecutable.cmake:47 (cmake_policy):
  Policy "CMP0167" is not known to this version of CMake.
Call Stack (most recent call first):
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1384 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2118 (_Boost_MISSING_DEPENDENCIES)
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2217 (message):
  No header defined for headers; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Error at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: headers) (found suitable version "1.81.0",
  minimum required is "1.64")
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


-- Configuring incomplete, errors occurred!
See also "/bitcoin/source_package/CMakeFiles/CMakeOutput.log".
See also "/bitcoin/source_package/CMakeFiles/CMakeError.log".
Build guix-win failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.

Tail of the build log:

-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-linux-gnu/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
-- Could NOT find Boost (missing: Boost_DIR)
CMake Error at cmake/modules/NativeExecutable.cmake:47 (cmake_policy):
  Policy "CMP0167" is not known to this version of CMake.
Call Stack (most recent call first):
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1384 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2118 (_Boost_MISSING_DEPENDENCIES)
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2217 (message):
  No header defined for headers; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Error at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: headers) (found suitable version "1.81.0",
  minimum required is "1.64")
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
  cmake/modules/NativeExecutable.cmake:48 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


-- Configuring incomplete, errors occurred!
See also "/bitcoin/source_package/CMakeFiles/CMakeOutput.log".
See also "/bitcoin/source_package/CMakeFiles/CMakeError.log".
Build guix-linux failed with exit code 1

Fabien planned changes to this revision.Mon, Dec 30, 15:53

Only set the policy if it exists

@bot guix-linux guix-osx guix-win

teamcity updated a token.Mon, Dec 30, 20:51

Harbormaster completed remote builds in B31838: Diff 51855.Mon, Dec 30, 21:08

Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.

Tail of the build log:

-- Found SHLWAPI component shlwapi: /gnu/store/5gbqxxax5n19hm86lal6s9qj3cccqlf3-mingw-w64-x86_64-winpthreads-12.0.0/lib/libshlwapi.a
-- Found SHLWAPI: /gnu/store/5gbqxxax5n19hm86lal6s9qj3cccqlf3-mingw-w64-x86_64-winpthreads-12.0.0/include   
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-w64-mingw32/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-w64-mingw32/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1384 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2118 (_Boost_MISSING_DEPENDENCIES)
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2217 (message):
  No header defined for headers; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Error at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: headers) (found suitable version "1.81.0",
  minimum required is "1.64")
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


-- Configuring incomplete, errors occurred!
See also "/bitcoin/source_package/CMakeFiles/CMakeOutput.log".
See also "/bitcoin/source_package/CMakeFiles/CMakeError.log".
Build guix-win failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.

Tail of the build log:

-- Looking for C++ include atomic - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Failed
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-apple-darwin/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1384 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2118 (_Boost_MISSING_DEPENDENCIES)
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2217 (message):
  No header defined for headers; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Error at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: headers) (found suitable version "1.81.0",
  minimum required is "1.64")
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


-- Configuring incomplete, errors occurred!
See also "/bitcoin/source_package/CMakeFiles/CMakeOutput.log".
See also "/bitcoin/source_package/CMakeFiles/CMakeError.log".
Build guix-osx failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.

Tail of the build log:

-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE  
-- Performing Test ENABLE_HWCRC32
-- Performing Test ENABLE_HWCRC32 - Success
-- Performing Test have_C__pedantic
-- Performing Test have_C__pedantic - Success
-- Performing Test have_C__Wshadow
-- Performing Test have_C__Wshadow - Success
-- Performing Test have_C__Wundef
-- Performing Test have_C__Wundef - Success
-- Performing Test have_C__Wno_unused_function
-- Performing Test have_C__Wno_unused_function - Success
-- Performing Test have_C__Wno_overlength_strings
-- Performing Test have_C__Wno_overlength_strings - Success
-- Performing Test have_C__std_c89
-- Performing Test have_C__std_c89 - Success
-- Performing Test have_C__Wno_long_long
-- Performing Test have_C__Wno_long_long - Success
-- Performing Test have_C__Wno_duplicated_branches
-- Performing Test have_C__Wno_duplicated_branches - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Found PkgConfig: /home/bitcoinabc/.guix-profile/bin/pkg-config (found version "0.29.2") 
-- Found Event component event: /bitcoin/depends/x86_64-linux-gnu/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1384 (message):
  New Boost version may have incorrect or missing dependencies and imported
  targets
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2118 (_Boost_MISSING_DEPENDENCIES)
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Warning at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2217 (message):
  No header defined for headers; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


CMake Error at /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: headers) (found suitable version "1.81.0",
  minimum required is "1.64")
Call Stack (most recent call first):
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FindBoost.cmake:2376 (find_package_handle_standard_args)
  cmake/modules/NativeExecutable.cmake:50 (find_package)
  src/CMakeLists.txt:511 (non_native_target_link_boost_headers_only)
  src/CMakeLists.txt:514 (link_boost_headers_only)


-- Configuring incomplete, errors occurred!
See also "/bitcoin/source_package/CMakeFiles/CMakeOutput.log".
See also "/bitcoin/source_package/CMakeFiles/CMakeError.log".
Build guix-linux failed with exit code 1

There is no component on FindBoost for the headers target

Fix indentation

Fix tab vs spaces

@bot guix-linux guix-osx guix-win

teamcity updated a token.Mon, Dec 30, 21:49

Harbormaster completed remote builds in B31839: Diff 51856.Mon, Dec 30, 21:56

Harbormaster completed remote builds in B31840: Diff 51857.Mon, Dec 30, 22:07

Harbormaster completed remote builds in B31841: Diff 51858.Mon, Dec 30, 22:10

PiRK accepted this revision.Tue, Dec 31, 09:49

This revision is now accepted and ready to land.Tue, Dec 31, 09:49

Closed by commit rABCe2f5b0bdbd81: [cmake] Handle FindBoost.cmake deprecation (authored by Fabien). · Explain WhyTue, Dec 31, 09:51

This revision was automatically updated to reflect the committed changes.