[Cashtab] Show cumulative depth bars on OrderBook to match normal exchange UX
ClosedPublic
Actions

Authored by bytesofman on Mon, Dec 30, 17:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfe5c41c6eb8b: [Cashtab] Show cumulative depth bars on OrderBook to match normal exchange UX

Summary

The current setup is confusing. Make depth bars cumulative so it looks like any other exchange OrderBook.

Test Plan

npm test, check screenshots.

can also check the dev site at https://cashtab-local-dev.netlify.app/ (make sure to hard refresh)

I considered adding this to integration tests but I think the impact of confirming css widths is detrimental. The calc here is not particularly complicated and it's immediately obvious if stuff is loading improperly.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mon, Dec 30, 17:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 30, 17:16

bytesofman mentioned this in D17426: [Cashtab] Do not show wild-ass agora offers in OrderBook.Mon, Dec 30, 17:17

improve comments

Harbormaster completed remote builds in B31834: Diff 51847.Mon, Dec 30, 17:21

bytesofman published this revision for review.Mon, Dec 30, 17:23

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B31835: Diff 51848.Mon, Dec 30, 17:25

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <Agora /> We can see multiple offers, some we made, others we did not, and we can cancel an offer ======
Error: expect(received).toBeInTheDocument()

received value must be an HTMLElement or an SVGElement.
Received has value: undefined
    at __EXTERNAL_MATCHER_TRAP__ (/work/cashtab/node_modules/expect/build/index.js:325:30)
    at Object.throwingMatcher [as toBeInTheDocument] (/work/cashtab/node_modules/expect/build/index.js:326:15)
    at Object.toBeInTheDocument (/work/cashtab/src/components/Agora/__tests__/index.test.js:650:11)

Each failure log is accessible here:
CashTab Unit Tests: <Agora /> We can see multiple offers, some we made, others we did not, and we can cancel an offer