Paths

Table of Contentst

Differential D17439

[e.cash] Add Swapspace widget
ClosedPublic
Actions

Authored by johnkuney on Tue, Dec 31, 04:31.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC3b6dd3e26a3e: [e.cash] Add Swapspace widget

Summary

Adding the Swapspace widget next to the Swapzone widget on /get-ecash as requested

Test Plan

Preview the site and check the widget

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-add-swapzone

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31846
Build 63184: Build Diff
Build 63183: arc lint + arc unit

Event Timeline

johnkuney created this revision.Tue, Dec 31, 04:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 31, 04:31

johnkuney requested review of this revision.Tue, Dec 31, 04:31

Harbormaster completed remote builds in B31846: Diff 51863.Tue, Dec 31, 04:31

@bot preview-e.cash

web/e.cash/pages/get-ecash.js
108–110

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41622 for the next 60 minutes.

any way we can clean up this scrollbar?

This revision now requires changes to proceed.Tue, Dec 31, 06:34

fix copy

Harbormaster completed remote builds in B31858: Diff 51880.Tue, Dec 31, 18:31

hmm I wasn't able to target the iframe scrollbars afaict. Thats weird yours are looking like that though, mine have the custom scrollbar styles
How does the widget look for you on this page https://swapzone.io/partners/exchange-widget ?

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41732 for the next 60 minutes.

In D17439#396615, @johnkuney wrote:

hmm I wasn't able to target the iframe scrollbars afaict. Thats weird yours are looking like that though, mine have the custom scrollbar styles
How does the widget look for you on this page https://swapzone.io/partners/exchange-widget ?

looks ok on their site in brave. looks same for me here in brave, ok in Firefox.

Would prob need to make the div full height to get rid of it if it's not targetable. mb this is ok, although where we're at now the other widget is already "too tall". mb would look better to just stack them instead of trying to render them next to each other?

will leave that up to you. i dunno if we can really push it looking like this for chrome/brave tho

web/e.cash/pages/get-ecash.js
109 ↗	(On Diff #51880)	my bad, the `---` is a markdown convention for "em dash" (`—`) ... but this isn't working here. just use `—`

This revision now requires changes to proceed.Tue, Dec 31, 19:42

dont show side by side, copy edit

Harbormaster completed remote builds in B31899: Diff 51936.Thu, Jan 2, 21:05

Okay how about this? fyi those styles on swapspace are what they have in their instructions for the widget

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41535 for the next 60 minutes.

looks much better

in general ... I don't think a user would want these widgets side by side anyway. It is a "one or the other" kind of thing. But that does mean whichever one shows first will prob get more use.

This revision is now accepted and ready to land.Thu, Jan 2, 21:20

Closed by commit rABC3b6dd3e26a3e: [e.cash] Add Swapspace widget (authored by johnkuney). · Explain WhyFri, Jan 3, 00:55

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC3b6dd3e26a3e: [e.cash] Add Swapspace widget.