Page MenuHomePhabricator

[cashtab] Don't display token type (SLP, ALP, etc.) in tx history
ClosedPublic

Authored by Fabien on Thu, Jan 2, 20:03.

Details

Summary

This is a wallet, users don't care (and shouldn't care) about the technology behind the scene.
The information is already available on the token page for the curious.

Test Plan
npm run test
npm run start

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Thu, Jan 2, 20:03

Tail of the build log:

  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.2.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

/work/modules/ecash-agora /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3310 packages in 25s

320 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (6 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.9.2 build
> node scripts/build.js

Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

[eslint] 
src/components/Home/Tx/index.tsx
  Line 230:35:  'parsedTokenType' is assigned a value but never used  @typescript-eslint/no-unused-vars


Build cashtab-tests failed with exit code 1
bytesofman added a subscriber: bytesofman.

a screenshot of "before" and "after" example can also help with this kind of diff review

This revision is now accepted and ready to land.Thu, Jan 2, 20:48