Page MenuHomePhabricator

[ecash-lib] Patch for nodejs tx building
ClosedPublic

Authored by bytesofman on Fri, Jan 3, 20:34.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC8909966d4893: [ecash-lib] Patch for nodejs tx building
Summary

Attempting to accept agora txs generates a crazy rabbit hole of an error that, if followed, will lead you here. This instanceof check fails in nodejs.

Cashtab does this with no problems but nodejs apps can't.

There are probably more issues like this and potentially we need a more general fix. But I am still learning about the issue.

For now, if we know this works and does not break existing use cases, I think we should go with it. The issue is known and improvements can build on this.

Test Plan

CI tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable